gh-145378: Generate consistent colors for pdb commands#149305
Open
gaogaotiantian wants to merge 4 commits intopython:mainfrom
Open
gh-145378: Generate consistent colors for pdb commands#149305gaogaotiantian wants to merge 4 commits intopython:mainfrom
gaogaotiantian wants to merge 4 commits intopython:mainfrom
Conversation
Documentation build overview
5 files changed ·
|
corona10
reviewed
May 3, 2026
| return None | ||
|
|
||
| def gen_colors(self, buffer): | ||
| from _pyrepl.utils import ColorSpan, Span |
Member
There was a problem hiding this comment.
Just nit comment, now we can use lazy import right?
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We supported pyrepl for pdb input. We used the default pyrepl color scheme which works most of the time. However, for pdb commands, they are not recognized. There are also some pdb commands (list, continue) that would be recognized as different things in pyrepl.
We should recognize those commands and use a consistent color for it. It's actually pretty helpful because users will (probably) realize that
a = 1won't work becauseahas a special color (ais a command forarg).